Bootstrap testing #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a unit test for the baseline configuration - All mocks are extracted into `conftest.py` - Add fixture files for `hardware-configuration.nix` and `kbd-model-map` - Add a nix flake for running and developing the tests - Add instructions to README.md - Configure github actions to run tests on all pull requests
|
You can see on my fork that the github actions job works fine (and only takes 25 seconds): https://github.com/lulu-berlin/calamares-nixos-extensions/actions/runs/10458771458/job/28961314243 |
Merged
|
@vlinkz, it occurred to me that it might be unclear what this PR does exactly or how it does it. Would it help if I added documentation explaining how it works and what it tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #44 by bootstrapping testing and implementing one unit test.
Changes:
conftest.pyhardware-configuration.nixandkbd-model-map@vlinkz @ElvishJerricco